search

haystack / nb

12 stars 10 forks source link

When page content change, some annotations wont appear #90

Closed JumanaFM closed 3 years ago

JumanaFM commented 3 years ago

If the location of an annotation was changed due to changes in the content, that annotation wont appear. How do we want to handle this? Do we ignore the error? Do we show the comment with no highlight?

example: we get this error on this page

image

@karger @lihelennn

lihelennn commented 3 years ago

From the error, App.js line 385 seems to be where we try to deserialize the thread range into something that can be rendered on the html page. I think that if we cannot deserialize it, we will catch the error and not display that thread

Should we add the functionality to still show the comment but maybe not the highlight?