haystackeditor / haystack-editor

Other
843 stars 34 forks source link

Powershell 7 terminal integration not loading correctly #21

Open WillemToorenburgh opened 1 month ago

WillemToorenburgh commented 1 month ago

Summary

Something in my Powershell profile (linked above) is causing Haystack to fail to correctly initialize a Powershell session. It leaves the terminal session in a damaged but usable state, with incorrect prompt text (failed escapes?) and playing an error bell with every command issued. Disabling my profile by adding -NoProfile to the launch arguments in Haystack settings prevents the issue.

I'm reporting this here as the same profile and environment does not cause issues on current VSCode. I believe I remember it happening in VSCode at one point in the past, so this could be solved by rebasing on a newer version of the upstream.

Images

VSCode vs Haystack

Haystack bad pwsh parse

Context

Does this issue occur when all extensions are disabled?: Yes

Haystack Version (also note the typo'd string interpolation for the "About Haystack" window) Haystack Version: 0.19.1
VS Code Version: 1.90.0 (user setup)
Chromium: 122.0.6261.156
OS: {3 }
Installed Extensions ``` aaron-bond.better-comments atlassian.atlascode christopherhx.azure-pipelines-vscode-ext davidanson.vscode-markdownlint eamodio.gitlens formulahendry.code-runner github.vscode-pull-request-github grapecity.gc-excelviewer mechatroner.rainbow-csv mjcrouch.perforce ms-azure-devops.azure-pipelines ms-azuretools.vscode-azureresourcegroups ms-azuretools.vscode-docker ms-vscode-remote.remote-containers ms-vscode-remote.remote-ssh ms-vscode-remote.remote-ssh-edit ms-vscode-remote.remote-wsl ms-vscode-remote.vscode-remote-extensionpack ms-vscode.azure-account ms-vscode.azurecli ms-vscode.hexeditor ms-vscode.powershell ms-vscode.remote-explorer ms-vscode.remote-server ms-vsliveshare.vsliveshare oderwat.indent-rainbow pspester.pester-test redhat.vscode-yaml robbowen.synthwave-vscode tamasfe.even-better-toml usernamehw.errorlens vscode-icons-team.vscode-icons yzhang.markdown-all-in-one ```
VS Code Version Version: 1.93.1 (system setup)
Commit: 38c31bc77e0dd6ae88a4e9cc93428cc27a56ba40
Date: 2024-09-11T17:20:05.685Z
Electron: 30.4.0
ElectronBuildId: 10073054
Chromium: 124.0.6367.243
Node.js: 20.15.1
V8: 12.4.254.20-electron.0
OS: Windows_NT x64 10.0.19045

OS Version: Windows 10 Pro 22H2

Powershell Info:

Name                           Value
----                           -----
PSVersion                      7.4.5
PSEdition                      Core
GitCommitId                    7.4.5
OS                             Microsoft Windows 10.0.19045
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}       
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Steps to Reproduce:

  1. Set up a Powershell environment like mine, using my profile.ps1 as reference
  2. Open up a Powershell terminal in Haystack