search

hazdzz / STGCN

The PyTorch implementation of STGCN.
GNU Lesser General Public License v2.1
484 stars 106 forks source link

Can u achieve the claimed MAE/RMSE of the STGCN paper? #9

Closed michealowen closed 3 years ago

michealowen commented 3 years ago

I use the pytorch implementation of repo https://github.com/FelixOpolka/STGCN-PyTorch.git to train on PEMSD7-M, but i can not achieve similar result.

hazdzz commented 3 years ago

I use the pytorch implementation of repo https://github.com/FelixOpolka/STGCN-PyTorch.git to train on PEMSD7-M, but i can not achieve similar result.

You don't need to. The author's code is wrong, so made other third parties code wrong either. I fixed the code totally. You can see the result from the correct code is very good.

michealowen commented 3 years ago

I use the pytorch implementation of repo https://github.com/FelixOpolka/STGCN-PyTorch.git to train on PEMSD7-M, but i can not achieve similar result.

You don't need to. The author's code is wrong, so made other third parties' code wrong either. I fixed the code totally. You can see the result from the correct code is very good.

Thank you, I will have a try.