Enhance env variable options

hazelcast / charts

Hazelcast Official Helm Chart Repository

Apache License 2.0

36 stars 88 forks source link

Enhance env variable options #361

Closed faisal-khalique closed 10 months ago

faisal-khalique commented 1 year ago

It should be possible to aggregate environment variables from multiple values.yaml files. Describing the env variables as array object limits the flexibility and leads to lot of duplicated code (or config) which can be avoided if we use map objects for setting environment variables. This PR adds the options of setting environment variables from

simple key-value pairs
key-value pairs for fetching fields from field reference
key-object pairs for fetching fields from secrets

faisal-khalique commented 1 year ago

@devOpsHazelcast - Can you please check this change? Appreciate the help.

semihbkgr commented 1 year ago

Hi @faisal-khalique

Thanks for the PR. These changes seem like breaking the compatibility with the older versions. We attach great importance to backward compatibility. If it doesn't improve the user experience pretty well or fix a bug, we don't lean to add these kind of changes which break the backward compatibility.

Can you explain more why do you need these changes?

devOpsHazelcast commented 10 months ago

PR closed by Hazelcast automation as no activity (>3 months). Please reopen with comments, if necessary. Thank you for using Hazelcast and your valuable contributions