HZC-2082: Hazelcast Version Improvements

hazelcast / hazelcast-cloud-cli

CLI for Hazelcast Cloud

Apache License 2.0

2 stars 5 forks source link

HZC-2082: Hazelcast Version Improvements #30

Closed huseyinbabal closed 2 years ago

huseyinbabal commented 2 years ago

Note: This PR depends on a task that should be released to prod first, will stay as draft until then.

Hazelcast new go sdk is used to be able to pass correct hazelcast versions.

Tested with current prod (3.4.0)

Properly reports starter hz versions Screen Shot 2022-01-20 at 12 34 34

Properly reports enterprise hz versions Screen Shot 2022-01-20 at 12 35 31

Holmistr commented 2 years ago

I find confusing that the name of https://github.com/hazelcast/hazelcast-cloud-cli/pull/30/files#diff-bd7621e04546158d6db8b00f3cdaa57dbb1dc9a4e616165eaf1eeaf6ada2172bR58 is "Release name". In the GUI, it's "Cluster name".

huseyinbabal commented 2 years ago

I find confusing that the name of https://github.com/hazelcast/hazelcast-cloud-cli/pull/30/files#diff-bd7621e04546158d6db8b00f3cdaa57dbb1dc9a4e616165eaf1eeaf6ada2172bR58 is "Release name". In the GUI, it's "Cluster name".

Release name is something specific to cloud, and cluster name is already used for title :) do you have any alternatives to cluster name?

Holmistr commented 2 years ago

Maybe "Discovery cluster name"? Or something like that? "Cluster connection name"? Just brainfarting.

huseyinbabal commented 2 years ago

Maybe "Discovery cluster name"? Or something like that? "Cluster connection name"? Just brainfarting.

Ok let's proceed with

{
...
    "displayName": "clustername",
    "clusterName": "pr-12345",
...
}

Holmistr commented 2 years ago

Fantastic enhancement, definitely will provide smoother CLI experience. Thanks!