search

hazelcast / hazelcast-code-samples

Hazelcast Code Samples
www.hazelcast.org
548 stars 594 forks source link

Fix HZ version [5.4.z] #642

Closed nishaatr closed 2 months ago

nishaatr commented 3 months ago

We just branched 5.4.1 from 5.4.z and didn't actually create 5.4.1 branch in Code Samples as it is EE only release This change will update to 5.4.2-SNAPSHOT ready for next release This in similar vein as https://github.com/hazelcast/hazelcast-mono/blob/5.4.z/pom.xml

image

Planning to fix this as part of DI-147

Fixes REL-281

nishaatr commented 3 months ago

PR build has filed https://jenkins.hazelcast.com/job/hazelcast-code-samples-pr-builder/654/console

13:54:11 [ERROR] Failed to execute goal on project clients: Could not resolve dependencies for project book.hazelcast.client:clients:pom:0.1-SNAPSHOT
13:54:11 [ERROR] dependency: com.hazelcast:hazelcast:jar:5.4.2-SNAPSHOT (compile)
13:54:11 [ERROR]    Could not find artifact com.hazelcast:hazelcast:jar:5.4.2-SNAPSHOT in snapshot-repository (https://oss.sonatype.org/content/repositories/snapshots)

This is expected as we don't have 5.4.2-SNAPSHOT

I will just merge once approved as this is normally update by automation without PR

JackPGreen commented 3 months ago

I'm not sure about this fix. I thought we discussed splitting the Hazelcast EE & OS versions for these projects? IMO there's no value in public code-samples that can't be built without private artefacts?

nishaatr commented 3 months ago

I'm not sure about this fix. I thought we discussed splitting the Hazelcast EE & OS versions for these projects? IMO there's no value in public code-samples that can't be built without private artefacts?

Not sure about splitting OS/EE but DI-147 will introduce a new prop to track next release. The release pipeline uses to set version in release, z-branch and master in here. The version are kept in sync with Mono, Docker and Packagin

This is how it works at the moment and if we don't update this then next 5.4 version will get out of sync (i.e. Samples will be 5.4.1 while Mono etc will be 5.4.2) which we can't have

UPDATE: Should clear-up that we only do EE Patch releases so this change is onyl actually needed if we happen to do full OS/EE 5.4.n patch release which unlikely. But I prefer to update to keep it in sync just in case