hazelcast / hazelcast-cpp-client

Hazelcast IMDG C++ Client
https://hazelcast.com/clients/cplusplus/
Apache License 2.0
80 stars 44 forks source link

Fix PR Builder failing to start #1231

Closed JackPGreen closed 1 month ago

JackPGreen commented 1 month ago

The PR builder is failing to even start the tests due to remote controller now requiring Java 17.

This is non-trivial to fix, as several other things have also broken in the meantime.

Force-merge required:

.github/workflows/build-pr.yml is configured to use use pull_request_target, rather than pull_request - to allow execution of the action on the target repository/branch, allowing it's secrets to be accessed. The problem with this is what when these scripts contain an issue, even if modified in a PR, the existing scripts will still be executed - meaning it's impossible to get the PR builder to pass, whatever you modify. As such, I've executed this PR in a branch (over a fork) and amended this behavior, so that the execution of this PR build can be properly observed in a test run on a previous revision. This PR will then require a force-merge. Ideally this behaviour should change, but out-of-scope for this PR.

Changes:

Fixes: https://github.com/hazelcast/hazelcast-cpp-client/issues/1222, https://github.com/hazelcast/hazelcast-cpp-client/issues/1229, https://github.com/hazelcast/hazelcast-cpp-client/pull/1207, https://github.com/hazelcast/hazelcast-cpp-client/pull/1226

JackPGreen commented 1 month ago

@ihsandemir are you able to take a look at this PR, please?