This is non-trivial to fix, as several other things have also broken in the meantime.
Force-merge required:
.github/workflows/build-pr.yml is configured to use use pull_request_target, rather than pull_request - to allow execution of the action on the target repository/branch, allowing it's secrets to be accessed.
The problem with this is what when these scripts contain an issue, even if modified in a PR, the existing scripts will still be executed - meaning it's impossible to get the PR builder to pass, whatever you modify.
As such, I've executed this PR in a branch (over a fork) and amended this behavior, so that the execution of this PR build can be properly observed in a test run on a previous revision.
This PR will then require a force-merge.
Ideally this behaviour should change, but out-of-scope for this PR.
Changes:
Centralised configuration where possible
Java version
Java distribution
Hazelcast version
Upgraded Java runtimes to Java 17
Upgraded Hazelcast dependency from 5.3.0-SNAPSHOT to 5.3.0
the SNAPSHOT is no longer available
this is the nearest (although now outdated) direct replacement (can and should be upgraded - separately)
Explicitly install the right Java / Maven versions on the runners, in favour of the bundled (outdated) versions
Refactor use of maven-dependency-plugin to specify a version
Currently implicitly uses the version bundled with Maven - but this has broken following Maven upgrade
Picks a version (not the latest!) that supports a custom download destination and a custom repository simultaneously
Fix permissions issue installing boost on OSX
Fix error: unqualified call to 'std::move' by qualifying call
The PR builder is failing to even start the tests due to remote controller now requiring Java 17.
This is non-trivial to fix, as several other things have also broken in the meantime.
Force-merge required:
.github/workflows/build-pr.yml
is configured to use usepull_request_target
, rather thanpull_request
- to allow execution of the action on the target repository/branch, allowing it's secrets to be accessed. The problem with this is what when these scripts contain an issue, even if modified in a PR, the existing scripts will still be executed - meaning it's impossible to get the PR builder to pass, whatever you modify. As such, I've executed this PR in a branch (over a fork) and amended this behavior, so that the execution of this PR build can be properly observed in a test run on a previous revision. This PR will then require a force-merge. Ideally this behaviour should change, but out-of-scope for this PR.Changes:
5.3.0-SNAPSHOT
to5.3.0
SNAPSHOT
is no longer availablemaven-dependency-plugin
to specify a versionboost
on OSXerror: unqualified call to 'std::move'
by qualifying callFixes: https://github.com/hazelcast/hazelcast-cpp-client/issues/1222, https://github.com/hazelcast/hazelcast-cpp-client/issues/1229, https://github.com/hazelcast/hazelcast-cpp-client/pull/1207, https://github.com/hazelcast/hazelcast-cpp-client/pull/1226