Code review after nearcache

[sancar]

All possible issues related to near-cache implementation will be listed in this issue

[sancar]

• [ ] Following two methods should not be on HazelcastClient. internal::nearcache::NearCacheManager &getNearCacheManager(); serialization::pimpl::SerializationService &getSerializationService(); If they are needed on tests, we need to expose them some other way.

[sancar]

• [ ] Do we want to @Override tags copied from java ? Since there is no IDE support for that, I think they are not needed in cpp client.

[sancar]

• [ ] ProxyManager introduced but just MapProxy is created via it. All should be created with ProxyManager and old way should be removed.

[sancar]

• [ ] Eviction comparator config does not look like a solution fit to cpp. Since config and actual usage of comparator not bound to each other in compile time, there is a runtime cast. And this cast not safe. One solution might be the pass the comparator to getMap method via templates. The usage will be similar to std::map and Compare with a default comparator. See std::map class definition

template<
    class Key,
    class T,
    class Compare = std::less<Key>,
    class Allocator = std::allocator<std::pair<const Key, T> >
> class map;

• [ ] Simiar for SamplingBasedEvictionStrategy. EvictionStragey also seem to be causing same boiler plate code. Same solution with above can be applied here.

[sancar]

• [ ] template names like A E KS VS is hard to figure out. We need to make them self explanatory.

[sancar]

• [ ] DefaultNearCache template KS seems to be only Data. There are similar usages when base classes of DefaultNearcache is followed. If there is no other possiblity we need to get rid of templates.

[sancar]

• [ ] There are lots of usage of assert(0) where it seems in most of it is avoidable.

  template <typename V>
  class NearCacheRecord {
  ...
  virtual void setValue(const boost::shared_ptr<V> &value) {
      assert(0);
  }
  ...
  }

  For example the usage above can be converted to following without a problem.

  template <typename V>
  class NearCacheRecord {
  ...
  virtual void setValue(const boost::shared_ptr<V> &value) = 0;
  ...
  }

[sancar]

• [ ] EvictionConfig.setCompartor is not used. Need to be tested

[sancar]

[ ]DataStructureAdepter and IMapDataStructureAdapter can be removed

example last method of following method from NearCacheManager class is never used. And this seems to be only use of DataStructureAdepter and IMapDataStructureAdapter

 template<typename K, typename V, typename KS>
boost::shared_ptr<NearCache<KS, V> > getOrCreateNearCache(
                            const std::string &name, const config::NearCacheConfig<K, V> &nearCacheConfig,
                            std::auto_ptr<adapter::DataStructureAdapter<K, V> > &dataStructureAdapter) 

[sancar]

• [ ] There are unused and commented out codes in NearCacheManager ???

[sancar]

• [ ] invalidationListenerId in NearCachedClientMapProxy never used. Why ?