search

hazelcast / hazelcast-csharp-client

Hazelcast .NET Client
https://hazelcast.com/clients/dotnet/
Apache License 2.0
102 stars 49 forks source link

[API-2160] Add Nullable Support for Value Types on SQL Queries #872

Closed emreyigit closed 9 months ago

emreyigit commented 9 months ago

If result of a SQL query contains null values, .Net client throws. See #854 for more details. This is because although SQL supports null for primitive types. The client cannot handle it. I've added nullable support for fixed sized type which are primitive ones.

Also, current implementation were failing while parsing null or mixed result due to wrong assumptions on List. Defining a size during initialization, does not mean that the list created with null values. This is fixed in the PR.

netlify[bot] commented 9 months ago

Deploy Preview for silly-valkyrie-e996d9 failed.

Name Link
Latest commit e6784f71e0f61c2f91f9e1b3a2854677853a4068
Latest deploy log https://app.netlify.com/sites/silly-valkyrie-e996d9/deploys/65b258de6942930008077fad
codecov-commenter commented 9 months ago

Codecov Report

Attention: 1060 lines in your changes are missing coverage. Please review.

Comparison is base (7c75b2e) 84.87% compared to head (e6784f7) 80.76%. Report is 1 commits behind head on master.

Files Patch % Lines
src/Hazelcast.Net/Models/MapOptions.cs 31.69% 125 Missing :warning:
src/Hazelcast.Net/Models/QueryCacheOptions.cs 34.83% 58 Missing :warning:
src/Hazelcast.Net/Models/MapStoreOptions.cs 33.82% 45 Missing :warning:
src/Hazelcast.Net/Models/RingbufferOptions.cs 35.71% 45 Missing :warning:
...rotocol/Codecs/DynamicConfigAddCacheConfigCodec.cs 0.00% 40 Missing :warning:
...cast.Net/Models/CacheSimpleEntryListenerOptions.cs 0.00% 29 Missing :warning:
src/Hazelcast.Net/Models/Capacity.cs 10.00% 27 Missing :warning:
src/Hazelcast.Net/Models/WanReplicationRef.cs 31.57% 26 Missing :warning:
src/Hazelcast.Net/Models/RingbufferStoreOptions.cs 31.42% 24 Missing :warning:
src/Hazelcast.Net/NearCaching/NearCacheOptions.cs 67.60% 23 Missing :warning:
... and 42 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #872 +/- ## ========================================== - Coverage 84.87% 80.76% -4.12% ========================================== Files 941 1018 +77 Lines 22346 24496 +2150 ========================================== + Hits 18966 19783 +817 - Misses 3380 4713 +1333 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.