search

hazelcast / hazelcast-csharp-client

Hazelcast .NET Client
https://hazelcast.com/clients/dotnet/
Apache License 2.0
102 stars 49 forks source link

Make `ensure-server-files` use `hazelcast-mono` #909

Closed JackPGreen closed 3 months ago

JackPGreen commented 3 months ago

ensure-server-files downloads hazelcast-default.xml from the hazelcast repo.

This failed, now that we have EE specific patches, where corresponding tags do not exist in hazelcast-mono:

Downloading hazelcast-default.xml -> hazelcast-5.4.1-SNAPSHOT.xml... Failed to download hazelcast-default.xml (404) from tag v5.4.1

Updated script to:

emreyigit commented 3 months ago

I see the changes but this is a public repo. How user will run it?

JackPGreen commented 3 months ago

I see the changes but this is a public repo. How user will run it?

They won't be able to - but isn't that where we already are with private SNAPSHOT repositories etc?

You could make it check hazelcast first, and if it's not found then check hazelcast-mono

srknzl commented 3 months ago

one build failed, (windows-latest+net8.0) I restarted it