search

hazelcast / hazelcast-csharp-client

Hazelcast .NET Client
https://hazelcast.com/clients/dotnet/
Apache License 2.0
102 stars 48 forks source link

Fix CP Group Name in CP Objects [API-2252] #913

Closed emreyigit closed 1 month ago

emreyigit commented 1 month ago

The PR fixes wrong usage of CP groups. Before the introduced fix, the client was sending the CP group creation requests in wrong format. This was resulting that all CP objects created in default CP group. Now, it's fixed.

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.98%. Comparing base (a00048c) to head (0a8cc02).

Files Patch % Lines
src/Hazelcast.Net/CP/CPSubsystem.cs 90.90% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #913 +/- ## ========================================== - Coverage 81.07% 80.98% -0.10% ========================================== Files 1031 1031 Lines 25047 25047 ========================================== - Hits 20307 20284 -23 - Misses 4740 4763 +23 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.