hazelcast / hazelcast-docker

This repository contains docker image for Hazelcast open-source in-memory data-grid.
Apache License 2.0
89 stars 82 forks source link

Use private OS distribution ZIPs in preference to public ones [DI-95] #747

Closed JackPGreen closed 5 months ago

JackPGreen commented 6 months ago

SNAPSHOT OS distribution ZIPs (e.g. those indexed here) will no longer be generated, which causes problems with the hazelcast-docker PR builder (amongst others).

Instead, the distribution ZIPs will be uploaded to a private AWS S3 bucket, which requires authentication.

This was a non-trivial change:

For testing, I've been doing what I can locally to assert the results between master and my branch are the same:

Fixes: DI-95

JackPGreen commented 6 months ago

@ldziedziul following a conversation with @nishaatr I've reverted removing the HZ_VERSION property, but made it explicit what it it is / isn't used for.

40ee80780818094500949572aa5914b25812968d

nishaatr commented 6 months ago

@ldziedziul following a conversation with @nishaatr I've reverted removing the HZ_VERSION property, but made it explicit what it it is / isn't used for.

Thanks @JackPGreen. Looks good.

@ldziedziul we are keeping the new way to decide which Docker image edition(s) to build i.e. OSS, EE or ALL. This is more explicit and neater as opposed to relying on EE/OSS Dockerfile updates. The HZ_VERSION will continue to be updated by the release pipeline as it is now to keep track of the version used for creating release and maintenance branches. I looked at the code and removing HZ_VERSION is a pain and cannot do without it - as we need to keep track of the version in the Dockerfile to create the correctly named branches

JackPGreen commented 6 months ago

We need to make sure that it will work with hazelcast-mono:

Workflows:

  • development-release-deploy-image.yml

Modules

  • hazelcast-docker-slim/pom.xml
  • hazelcast-enterprise-it/pom.xml

Could you check these places?

I've looked and I don't see any issues there with this change.