Closed JackPGreen closed 5 months ago
@ldziedziul following a conversation with @nishaatr I've reverted removing the HZ_VERSION
property, but made it explicit what it it is / isn't used for.
40ee80780818094500949572aa5914b25812968d
@ldziedziul following a conversation with @nishaatr I've reverted removing the
HZ_VERSION
property, but made it explicit what it it is / isn't used for.
Thanks @JackPGreen. Looks good.
@ldziedziul we are keeping the new way to decide which Docker image edition(s) to build i.e. OSS, EE or ALL. This is more explicit and neater as opposed to relying on EE/OSS Dockerfile updates. The HZ_VERSION
will continue to be updated by the release pipeline as it is now to keep track of the version used for creating release and maintenance branches. I looked at the code and removing HZ_VERSION
is a pain and cannot do without it - as we need to keep track of the version in the Dockerfile to create the correctly named branches
We need to make sure that it will work with
hazelcast-mono
:Workflows:
- development-release-deploy-image.yml
Modules
- hazelcast-docker-slim/pom.xml
- hazelcast-enterprise-it/pom.xml
Could you check these places?
I've looked and I don't see any issues there with this change.
SNAPSHOT
OS distribution ZIPs (e.g. those indexed here) will no longer be generated, which causes problems with thehazelcast-docker
PR builder (amongst others).Instead, the distribution ZIPs will be uploaded to a private AWS S3 bucket, which requires authentication.
This was a non-trivial change:
Dockerfile
to be executed normally outside of a build (e.g. for the security scan)get_hz_dist_zip
intoos_build.functions
(and same for EE)maven.functions
script to support resolution of "latest released" for a given artifactxmllint
to all the runner images that build anything as required for the Maven stuffget_dist
OS script to generate a pre-signed S3 URL to get it from S3 rather than a Maven repositoryDockerfile
arguments - the URL resolution is now being done outside of theDockerfile
more of the time, meaning not always requiredHZ_VARIANT
parameterHZ_VERSION
from OS and reduced usage in EEFor testing, I've been doing what I can locally to assert the results between
master
and my branch are the same:build-pr.yml
doesn't pass locally for me on EE, I presume due to someact
incompatibility - so a milestone for my PR is to get the same failure in the same placeact
, just a plaindocker buildx build hazelcast-os
) and they build ok.Fixes: DI-95