search

hazelcast / hazelcast-docker

This repository contains docker image for Hazelcast open-source in-memory data-grid.
Apache License 2.0
89 stars 82 forks source link

Remove `suffix` parameter from scripts #754

Closed JackPGreen closed 5 months ago

JackPGreen commented 5 months ago

suffix is a hardcoded derivative of variant, and can instead be derived dynamically.

tag_image_push_rhel.yml used suffix, but never actually set it (unlike tag_image_push.yml which did), so hardcoded it to "" instead.

Fixes: https://github.com/hazelcast/hazelcast-docker/issues/753

JackPGreen commented 5 months ago

Am I missing something or matrix.suffix is not defined and always empty in tag_image_push_rhel.yml?

Glad it's not just me.

JackPGreen commented 5 months ago

Am I missing something or matrix.suffix is not defined and always empty in tag_image_push_rhel.yml?

Glad it's not just me.

Yes, it's empty: TAGS_TO_PUSH=$(get_tags_to_push 5.4.0 "" "17" "$DEFAULT_JDK")

JackPGreen commented 5 months ago

9f812ce78e7f0ca9c129e92d5b2abdc1f154b7a3

I've added the matrix to that job.