hazelcast / hazelcast-docker

This repository contains docker image for Hazelcast open-source in-memory data-grid.
Apache License 2.0
89 stars 82 forks source link

Fix flaky CLC installation in tests #757

Closed ldziedziul closed 5 months ago

ldziedziul commented 5 months ago

Use specific version as the downloading the latest version often fails:

Hazelcast CLC Installer (c) 2023 Hazelcast, Inc.

INFO  Creating the Home directory: /home/runner/.hazelcast
ERROR could not determine the latest version
Error: Process completed with exit code 1.

See also: https://hazelcast.slack.com/archives/C0319N7HV8W/p1718023112329759

ldziedziul commented 5 months ago

I don't like this:

  • who is going to maintain CLC_VERSION as the release increases?

I understand this causes downstream builds to fail but I think that's a symptom, not an issue to be worked around.

This is only a temporary workaround until CLC team will fix it, I'm not happy about it either but we shouldn't suffer because of it.

  • if the released version doesn't work, it's good were catching it (albeit in the wrong place)

It's not our responsibility, to be testers of CLC. Of course it's nice to test it as a side effect but it should effect our build pipelines.

The alternative would be to add retry mechanism instead:

 while ! curl https://hazelcast.com/clc/install.sh | bash
    do
      echo "Retrying..."
      sleep 3
    done

What do you think?

JackPGreen commented 5 months ago

I don't like this:

  • who is going to maintain CLC_VERSION as the release increases?

I understand this causes downstream builds to fail but I think that's a symptom, not an issue to be worked around.

This is only a temporary workaround until CLC team will fix it, I'm not happy about it either but we shouldn't suffer because of it.

  • if the released version doesn't work, it's good were catching it (albeit in the wrong place)

It's not our responsibility, to be testers of CLC. Of course it's nice to test it as a side effect but it should effect our build pipelines.

The alternative would be to add retry mechanism instead:

 while ! curl https://hazelcast.com/clc/install.sh | bash
    do
      echo "Retrying..."
      sleep 3
    done

What do you think?

I much prefer the second option.