Fix `test_published_images.yml` [DI-316]

hazelcast / hazelcast-docker

This repository contains docker image for Hazelcast open-source in-memory data-grid.

Apache License 2.0

89 stars 82 forks source link

Fix `test_published_images.yml` [DI-316] #827

Closed JackPGreen closed 1 week ago

JackPGreen commented 1 week ago

The action added in https://github.com/hazelcast/hazelcast-docker/pull/814 could not be properly tested via GitHub until merged and at that point additional defects were discovered.

Example of now successful completion.

Post-merge actions:

[ ] backport this + previous PRs to maintenance branches
[x] update release documentation to reference

Fixes: DI-316

ldziedziul commented 1 week ago

The action added in #814 could not be properly tested via GitHub until merged

You could simply merge an empty (or minimalistic) workflow to the master, and then test the workflow on the branch

JackPGreen commented 1 week ago

The action added in #814 could not be properly tested via GitHub until merged

You could simply merge an empty (or minimalistic) workflow to the master, and then test the workflow on the branch

I wasn’t sure what the eventual inputs would be (which is good as we changed them right at the end) and was worried GitHub would only let me use the inputs on master.

ldziedziul commented 1 week ago

I wasn’t sure what the eventual inputs would be (which is good as we changed them right at the end) and was worried GitHub would only let me use the inputs on master.

I'm pretty sure it will show input from the PR branch