search

hazelcast / hazelcast-nodejs-client

Hazelcast Node.js Client
https://hazelcast.com/clients/node-js/
Apache License 2.0
150 stars 59 forks source link

Fix NearCachedMapTest [API-1161] #1177

Closed srknzl closed 2 years ago

srknzl commented 2 years ago

This PR fixes a near cached map test race condition. My understanding is the following. If the delayed map1.get() call finishes before invalidation, the test fails with 1 hit count and 1 miss count where it should be 0 hit count and 2 miss counts. Increased timeout to be 5 seconds.

fixes #1176

codecov[bot] commented 2 years ago

Codecov Report

Merging #1177 (b3dd04f) into master (e695651) will decrease coverage by 0.39%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1177      +/-   ##
==========================================
- Coverage   92.53%   92.13%   -0.40%     
==========================================
  Files         438      438              
  Lines       14512    14512              
  Branches     1086     1086              
==========================================
- Hits        13428    13370      -58     
- Misses        797      848      +51     
- Partials      287      294       +7
Impacted Files Coverage Δ
src/codec/ClientAuthenticationCustomCodec.ts 42.22% <0.00%> (-33.34%) :arrow_down:
src/network/ConnectionManager.ts 75.35% <0.00%> (-8.46%) :arrow_down:
src/util/Util.ts 87.26% <0.00%> (-1.28%) :arrow_down:
src/config/ConfigBuilder.ts 90.13% <0.00%> (-1.10%) :arrow_down:
src/network/Connection.ts 94.22% <0.00%> (-0.89%) :arrow_down:
src/invocation/ClusterService.ts 94.01% <0.00%> (-0.86%) :arrow_down:
src/protocol/ErrorFactory.ts 64.66% <0.00%> (+0.75%) :arrow_up:
src/core/HazelcastError.ts 75.60% <0.00%> (+0.81%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e695651...b3dd04f. Read the comment docs.