search

hazelcast / hazelcast-nodejs-client

Hazelcast Node.js Client
https://hazelcast.com/clients/node-js/
Apache License 2.0
150 stars 59 forks source link

Isolate failing near cache test API-1161 #1196

Closed srknzl closed 2 years ago

srknzl commented 2 years ago

I think the test logic is correct. I ran the test on its own several times and could not get a fail. https://github.com/srknzl/hazelcast-nodejs-client/actions/runs/1880356435/attempts/1 (You can see all attempts in the attempts selector.)

I think isolating the test can fix the flakiness. To do that, I create a client before each test.

fixes #1176

codecov[bot] commented 2 years ago

Codecov Report

Merging #1196 (6ee9878) into master (940dce9) will decrease coverage by 0.37%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1196      +/-   ##
==========================================
- Coverage   92.52%   92.14%   -0.38%     
==========================================
  Files         440      440              
  Lines       14556    14556              
  Branches     1096     1096              
==========================================
- Hits        13468    13413      -55     
- Misses        801      851      +50     
- Partials      287      292       +5
Impacted Files Coverage Δ
src/codec/ClientAuthenticationCustomCodec.ts 42.22% <0.00%> (-33.34%) :arrow_down:
src/network/ConnectionManager.ts 75.82% <0.00%> (-7.99%) :arrow_down:
src/config/ConfigBuilder.ts 90.26% <0.00%> (-1.06%) :arrow_down:
src/invocation/ClusterService.ts 94.01% <0.00%> (-0.86%) :arrow_down:
src/proxy/MultiMapProxy.ts 96.40% <0.00%> (-0.72%) :arrow_down:
src/util/Util.ts 87.89% <0.00%> (-0.64%) :arrow_down:
src/core/HazelcastError.ts 75.20% <0.00%> (ø)
src/protocol/ErrorFactory.ts 63.90% <0.00%> (ø)
src/invocation/InvocationService.ts 94.69% <0.00%> (+0.44%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 940dce9...6ee9878. Read the comment docs.