search

hazelcast / hazelcast-nodejs-client

Hazelcast Node.js Client
https://hazelcast.com/clients/node-js/
Apache License 2.0
150 stars 59 forks source link

Convert MapLockTest to async/await API-1264 #1252

Closed srknzl closed 2 years ago

srknzl commented 2 years ago

This should fix the done being called twice error. The other fail is about writing to a writer after its connection is closed. I need to reproduce the issue to find the root cause but could not so far.

fixes #1230

codecov[bot] commented 2 years ago

Codecov Report

Merging #1252 (8f494ab) into master (a20a5b3) will decrease coverage by 0.37%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1252      +/-   ##
==========================================
- Coverage   92.55%   92.17%   -0.38%     
==========================================
  Files         440      440              
  Lines       14553    14553              
  Branches     1095     1095              
==========================================
- Hits        13469    13414      -55     
- Misses        797      848      +51     
- Partials      287      291       +4
Impacted Files Coverage Δ
src/codec/ClientAuthenticationCustomCodec.ts 42.22% <0.00%> (-33.34%) :arrow_down:
src/network/ConnectionManager.ts 75.35% <0.00%> (-8.46%) :arrow_down:
src/config/ConfigBuilder.ts 90.26% <0.00%> (-1.06%) :arrow_down:
src/invocation/ClusterService.ts 94.01% <0.00%> (-0.86%) :arrow_down:
src/util/Util.ts 87.89% <0.00%> (-0.64%) :arrow_down:
src/invocation/InvocationService.ts 94.24% <0.00%> (-0.45%) :arrow_down:
src/proxy/MultiMapProxy.ts 97.12% <0.00%> (+0.71%) :arrow_up:
src/protocol/ErrorFactory.ts 64.66% <0.00%> (+0.75%) :arrow_up:
src/core/HazelcastError.ts 76.00% <0.00%> (+0.79%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a20a5b3...8f494ab. Read the comment docs.