hazelcast / hazelcast-nodejs-client

Hazelcast Node.js Client
https://hazelcast.com/clients/node-js/
Apache License 2.0
150 stars 59 forks source link

Fix leak in ReliableTopicListenerRunner.next API-1514 #1380

Closed srknzl closed 2 years ago

srknzl commented 2 years ago

Clean cherry-picked backport of #1377

I will merge this PR with one approval.

codecov[bot] commented 2 years ago

Codecov Report

Merging #1380 (fe43afa) into 5.0.x (6612a0f) will decrease coverage by 0.45%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            5.0.x    #1380      +/-   ##
==========================================
- Coverage   92.64%   92.18%   -0.46%     
==========================================
  Files         438      438              
  Lines       16857    16857              
  Branches     1080     1080              
==========================================
- Hits        15617    15540      -77     
- Misses        959     1030      +71     
- Partials      281      287       +6     
Impacted Files Coverage Δ
src/proxy/topic/ReliableTopicListenerRunner.ts 84.31% <100.00%> (ø)
src/codec/ClientAuthenticationCustomCodec.ts 40.42% <0.00%> (-34.05%) :arrow_down:
src/network/ConnectionManager.ts 77.17% <0.00%> (-9.50%) :arrow_down:
src/config/ConfigBuilder.ts 93.82% <0.00%> (-2.78%) :arrow_down:
src/core/HazelcastError.ts 65.55% <0.00%> (-1.12%) :arrow_down:
src/invocation/InvocationService.ts 93.63% <0.00%> (-0.75%) :arrow_down:
src/protocol/ErrorFactory.ts 64.96% <0.00%> (-0.73%) :arrow_down:
src/invocation/ClusterService.ts 92.19% <0.00%> (-0.71%) :arrow_down:
src/util/Util.ts 88.05% <0.00%> (-0.63%) :arrow_down:
src/core/DateTimeClasses.ts 90.50% <0.00%> (+1.11%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more