search

hazelcast / hazelcast-nodejs-client

Hazelcast Node.js Client
https://hazelcast.com/clients/node-js/
Apache License 2.0
150 stars 59 forks source link

Send client state to cluster in re-connections[API-1644] #1415

Closed harunalpak closed 1 year ago

harunalpak commented 1 year ago

Related PR: https://github.com/hazelcast/hazelcast/pull/22164

codecov[bot] commented 1 year ago

Codecov Report

Merging #1415 (1f7388e) into master (871a812) will decrease coverage by 0.02%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1415      +/-   ##
==========================================
- Coverage   93.17%   93.14%   -0.03%     
==========================================
  Files         465      465              
  Lines       16430    16431       +1     
  Branches     1337     1337              
==========================================
- Hits        15308    15305       -3     
- Misses        823      825       +2     
- Partials      299      301       +2
Impacted Files Coverage Δ
src/network/ConnectionManager.ts 79.62% <100.00%> (+0.04%) :arrow_up:
src/network/Connection.ts 94.22% <0.00%> (-0.89%) :arrow_down:
src/util/Util.ts 86.30% <0.00%> (-0.69%) :arrow_down:
src/invocation/InvocationService.ts 95.29% <0.00%> (-0.40%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

harunalpak commented 1 year ago

Should we add a test? We cannot add split brain tests for obvious reasons but, can we add a test that will check if state is sent to the cluster after a reconnect? (could be in ClientReconnectTest, via using sinon spies/fakes)

Yes we should add this test to ensure that whether the state sent to cluster or not. I will add the test and send to PR.