Closed harunalpak closed 1 year ago
Merging #1415 (1f7388e) into master (871a812) will decrease coverage by
0.02%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #1415 +/- ##
==========================================
- Coverage 93.17% 93.14% -0.03%
==========================================
Files 465 465
Lines 16430 16431 +1
Branches 1337 1337
==========================================
- Hits 15308 15305 -3
- Misses 823 825 +2
- Partials 299 301 +2
Impacted Files | Coverage Δ | |
---|---|---|
src/network/ConnectionManager.ts | 79.62% <100.00%> (+0.04%) |
:arrow_up: |
src/network/Connection.ts | 94.22% <0.00%> (-0.89%) |
:arrow_down: |
src/util/Util.ts | 86.30% <0.00%> (-0.69%) |
:arrow_down: |
src/invocation/InvocationService.ts | 95.29% <0.00%> (-0.40%) |
:arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Should we add a test? We cannot add split brain tests for obvious reasons but, can we add a test that will check if state is sent to the cluster after a reconnect? (could be in ClientReconnectTest, via using sinon spies/fakes)
Yes we should add this test to ensure that whether the state sent to cluster or not. I will add the test and send to PR.
Related PR: https://github.com/hazelcast/hazelcast/pull/22164