search

hazelcast / hazelcast-nodejs-client

Hazelcast Node.js Client
https://hazelcast.com/clients/node-js/
Apache License 2.0
150 stars 58 forks source link

Revert "Change logic around closing connections and writers API-1283 (#1417)" #1430

Closed srknzl closed 1 year ago

srknzl commented 1 year ago

The change should have been merged after 5.2.0 release. Reverting until then.

This reverts commit 2d0b3975997c491143ab1b02364b789afe6f520d.

codecov[bot] commented 1 year ago

Codecov Report

Merging #1430 (2d0b397) into master (2d0b397) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 2d0b397 differs from pull request most recent head 6c49813. Consider uploading reports for the commit 6c49813 to get more accurate results

@@           Coverage Diff           @@
##           master    #1430   +/-   ##
=======================================
  Coverage   93.17%   93.17%           
=======================================
  Files         466      466           
  Lines       16623    16623           
  Branches     1351     1351           
=======================================
  Hits        15488    15488           
  Misses        832      832           
  Partials      303      303

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

srknzl commented 1 year ago

Merged with one approval as this is just a revert