harunalpak commented 1 year ago

BigDecimal, LocalDate, LocalTime, LocalDateTime, OffsetDateTime were added. BigDecimal[], LocalDate[], LocalTime[], LocalDateTime[], OffsetDateTime[] were skipped, because they have not any serialization on Nodejs. So these were not added.

Also [1.serialization.compatibility.binary] were created from Hazelcast repository.

devOpsHazelcast commented 1 year ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: harunalpak
:x: Harun

Harun seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

codecov[bot] commented 1 year ago

Codecov Report

Merging #1431 (23f7878) into master (67ea00f) will increase coverage by 0.05%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1431      +/-   ##
==========================================
+ Coverage   93.17%   93.22%   +0.05%     
==========================================
  Files         466      466              
  Lines       16616    16616              
  Branches     1348     1348              
==========================================
+ Hits        15482    15491       +9     
+ Misses        832      825       -7     
+ Partials      302      300       -2

Impacted Files	Coverage Δ
src/invocation/InvocationService.ts	`95.60% <0.00%> (+0.73%)`	:arrow_up:
src/network/ConnectionManager.ts	`79.81% <0.00%> (+1.16%)`	:arrow_up:
...rc/serialization/portable/DefaultPortableReader.ts	`85.00% <0.00%> (+1.42%)`	:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

hazelcast / hazelcast-nodejs-client

New types added to binary compatibility test for Portable [API-1677] #1431

Codecov Report