Closed harunalpak closed 1 year ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.
:white_check_mark: harunalpak
:x: Harun
Merging #1431 (23f7878) into master (67ea00f) will increase coverage by
0.05%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #1431 +/- ##
==========================================
+ Coverage 93.17% 93.22% +0.05%
==========================================
Files 466 466
Lines 16616 16616
Branches 1348 1348
==========================================
+ Hits 15482 15491 +9
+ Misses 832 825 -7
+ Partials 302 300 -2
Impacted Files | Coverage Δ | |
---|---|---|
src/invocation/InvocationService.ts | 95.60% <0.00%> (+0.73%) |
:arrow_up: |
src/network/ConnectionManager.ts | 79.81% <0.00%> (+1.16%) |
:arrow_up: |
...rc/serialization/portable/DefaultPortableReader.ts | 85.00% <0.00%> (+1.42%) |
:arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Related java issue: https://github.com/hazelcast/hazelcast/pull/22716/files
BigDecimal, LocalDate, LocalTime, LocalDateTime, OffsetDateTime were added. BigDecimal[], LocalDate[], LocalTime[], LocalDateTime[], OffsetDateTime[] were skipped, because they have not any serialization on Nodejs. So these were not added.
Also [1.serialization.compatibility.binary] were created from Hazelcast repository.