Closed harunalpak closed 1 year ago
Can you update the documentation as well? https://github.com/srknzl/hazelcast-nodejs-client/blob/192b7be3059916f33e1c31c10612bdd54364498e/DOCUMENTATION.md#L654
Merging #1432 (5e92ece) into master (815b3af) will increase coverage by
0.02%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #1432 +/- ##
==========================================
+ Coverage 93.34% 93.37% +0.02%
==========================================
Files 466 466
Lines 16616 16623 +7
Branches 1348 1351 +3
==========================================
+ Hits 15511 15522 +11
+ Misses 803 798 -5
- Partials 302 303 +1
Impacted Files | Coverage Δ | |
---|---|---|
src/util/Util.ts | 86.98% <100.00%> (ø) |
|
src/protocol/ErrorFactory.ts | 64.66% <0.00%> (-0.76%) |
:arrow_down: |
src/invocation/InvocationService.ts | 94.50% <0.00%> (ø) |
|
src/network/Connection.ts | 94.82% <0.00%> (+0.60%) |
:arrow_up: |
src/proxy/NearCachedMapProxy.ts | 94.44% <0.00%> (+1.38%) |
:arrow_up: |
src/nearcache/NearCache.ts | 93.79% <0.00%> (+1.55%) |
:arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
This is simple change, I only add toUpperCase().
I am not sure we need extra test for this. I added a sample test for logging.