Closed harunalpak closed 1 year ago
@mdumandag This means that compact won't work with a 5.1.z server. So it is a breaking change. Is this expected?
Merging #1435 (685323c) into master (67ea00f) will increase coverage by
0.02%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #1435 +/- ##
==========================================
+ Coverage 93.17% 93.19% +0.02%
==========================================
Files 466 466
Lines 16616 16616
Branches 1348 1348
==========================================
+ Hits 15482 15486 +4
+ Misses 832 827 -5
- Partials 302 303 +1
Impacted Files | Coverage Δ | |
---|---|---|
src/util/Util.ts | 86.30% <0.00%> (-0.69%) |
:arrow_down: |
src/invocation/InvocationService.ts | 94.87% <0.00%> (ø) |
|
src/network/ConnectionManager.ts | 79.81% <0.00%> (+1.16%) |
:arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
approving, discussed via slack. It is expected that we break compatiblity
Related to https://github.com/hazelcast/hazelcast-nodejs-client/pull/1418 this PR we added a new Codec named "SetUUIDCodec".
And this is used in SchemaService.put method.
And I check that it is also added to server version 5.2.0. (https://github.com/hazelcast/hazelcast/pull/22197)
IMO 'CompactTest' should run greater than 5.2.0 server version.