search

hazelcast / hazelcast-nodejs-client

Hazelcast Node.js Client
https://hazelcast.com/clients/node-js/
Apache License 2.0
150 stars 58 forks source link

Do not try to connect cluster members when the client is not connected to cluster [API-1588] #1444

Closed harunalpak closed 1 year ago

harunalpak commented 1 year ago

In java side firstly opened 21568 issue but this issue closed,

And instead of this issue 21705 is implemented and merged.

So our referance issue is 21705.

In this PR I only added Java ported test and also I wrote a new test related to this issue.

DISCONNECTED_FROM_CLUSTER implementation was implemented on Compact Serialization Update. For details you can check 1422

codecov[bot] commented 1 year ago

Codecov Report

Merging #1444 (19a07da) into master (815b3af) will increase coverage by 0.03%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1444      +/-   ##
==========================================
+ Coverage   93.34%   93.38%   +0.03%     
==========================================
  Files         466      466              
  Lines       16616    16623       +7     
  Branches     1348     1351       +3     
==========================================
+ Hits        15511    15524      +13     
+ Misses        803      799       -4     
+ Partials      302      300       -2
Impacted Files Coverage Δ
src/network/Connection.ts 94.82% <0.00%> (+0.60%) :arrow_up:
src/util/Util.ts 87.67% <0.00%> (+0.68%) :arrow_up:
src/invocation/InvocationService.ts 95.23% <0.00%> (+0.73%) :arrow_up:
...rc/serialization/portable/DefaultPortableReader.ts 85.00% <0.00%> (+1.42%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more