hazelcast / hazelcast-nodejs-client

Hazelcast Node.js Client
https://hazelcast.com/clients/node-js/
Apache License 2.0
150 stars 58 forks source link

Don't allow empty memberlist on cluster id changes[API-1590] #1448

Closed harunalpak closed 1 year ago

harunalpak commented 1 year ago

Related Java issue: https://github.com/hazelcast/hazelcast/pull/20818

I will add test asap. Firstly I sent the core implementation. I will update PR.

codecov[bot] commented 1 year ago

Codecov Report

Merging #1448 (e7fe630) into master (0d95751) will increase coverage by 0.07%. The diff coverage is 96.77%.

:exclamation: Current head e7fe630 differs from pull request most recent head 725bb49. Consider uploading reports for the commit 725bb49 to get more accurate results

@@            Coverage Diff             @@
##           master    #1448      +/-   ##
==========================================
+ Coverage   93.34%   93.41%   +0.07%     
==========================================
  Files         466      466              
  Lines       16623    16622       -1     
  Branches     1351     1350       -1     
==========================================
+ Hits        15517    15528      +11     
+ Misses        806      796      -10     
+ Partials      300      298       -2     
Impacted Files Coverage Δ
src/listener/ClusterViewListenerService.ts 100.00% <ø> (ø)
src/invocation/ClusterService.ts 97.34% <95.65%> (+2.47%) :arrow_up:
src/HazelcastClient.ts 93.44% <100.00%> (ø)
src/core/MembershipListener.ts 100.00% <100.00%> (ø)
src/network/Connection.ts 94.87% <100.00%> (+0.04%) :arrow_up:
src/network/ConnectionManager.ts 85.64% <100.00%> (+1.65%) :arrow_up:
src/util/Util.ts 86.98% <0.00%> (-0.69%) :arrow_down:
src/proxy/MultiMapProxy.ts 98.46% <0.00%> (-0.52%) :arrow_down:
src/core/HazelcastError.ts 78.35% <0.00%> (+0.74%) :arrow_up:
src/protocol/ErrorFactory.ts 65.41% <0.00%> (+0.75%) :arrow_up:
... and 3 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

srknzl commented 1 year ago

Superseeded by https://github.com/hazelcast/hazelcast-nodejs-client/pull/1452