search

hazelcast / hazelcast-nodejs-client

Hazelcast Node.js Client
https://hazelcast.com/clients/node-js/
Apache License 2.0
150 stars 58 forks source link

Don't allow empty memberlist on cluster id changes[API-1590] #1452

Closed srknzl closed 1 year ago

srknzl commented 1 year ago

Superseeds https://github.com/hazelcast/hazelcast-nodejs-client/pull/1448

codecov[bot] commented 1 year ago

Codecov Report

Merging #1452 (2c1c218) into master (895b041) will increase coverage by 0.06%. The diff coverage is 97.61%.

@@            Coverage Diff             @@
##           master    #1452      +/-   ##
==========================================
+ Coverage   93.39%   93.46%   +0.06%     
==========================================
  Files         466      466              
  Lines       16622    16628       +6     
  Branches     1350     1350              
==========================================
+ Hits        15524    15541      +17     
+ Misses        800      792       -8     
+ Partials      298      295       -3
Impacted Files Coverage Δ
src/invocation/ClusterService.ts 97.36% <96.29%> (+2.49%) :arrow_up:
src/HazelcastClient.ts 93.44% <100.00%> (ø)
src/core/MembershipListener.ts 100.00% <100.00%> (ø)
src/listener/ClusterViewListenerService.ts 100.00% <100.00%> (ø)
src/network/Connection.ts 95.72% <100.00%> (+0.89%) :arrow_up:
src/network/ConnectionManager.ts 85.35% <100.00%> (+1.36%) :arrow_up:
src/proxy/MultiMapProxy.ts 98.46% <0.00%> (-0.52%) :arrow_down:
... and 1 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more