search

hazelcast / hazelcast-nodejs-client

Hazelcast Node.js Client
https://hazelcast.com/clients/node-js/
Apache License 2.0
150 stars 58 forks source link

Remove getOrConnectToMember assertion because it is also called by triggerClusterReconnection #1504

Closed srknzl closed 1 year ago

srknzl commented 1 year ago

The test is added after reflecting this change to java https://github.com/hazelcast/hazelcast/pull/21705/files.

as can be seen, in this change, we are only changing the smart client reconnection task's logic. It should not call getOrConnectToMember. However, in the node.js test we added an assertion that checks that getOrConnectToMember should not be called at all. First of all, this logic does not exist in the java test and second, triggerClusterReconnection will also call getOrConnectToMember. Therefore, our assertion is not correct. I removed it.

related node.js backw compatiblity test: https://github.com/hazelcast/client-compatibility-suites/actions/runs/5253301597/jobs/9490454007

codecov[bot] commented 1 year ago

Codecov Report

Merging #1504 (a97545b) into master (a896ca8) will increase coverage by 0.03%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1504      +/-   ##
==========================================
+ Coverage   93.42%   93.45%   +0.03%     
==========================================
  Files         466      466              
  Lines       16628    16628              
  Branches     1350     1350              
==========================================
+ Hits        15535    15540       +5     
+ Misses        798      794       -4     
+ Partials      295      294       -1

see 4 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more