hazelcast / hazelcast-nodejs-client

Hazelcast Node.js Client
https://hazelcast.com/clients/node-js/
Apache License 2.0
150 stars 58 forks source link

Update dependency:get command to latest syntax #1507

Closed JackPGreen closed 11 months ago

JackPGreen commented 1 year ago

Port of the resolution to the issue described in https://github.com/hazelcast/hazelcast-cpp-client/pull/1206

codecov[bot] commented 1 year ago

Codecov Report

Merging #1507 (e329599) into master (f571254) will decrease coverage by 0.02%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1507      +/-   ##
==========================================
- Coverage   93.46%   93.45%   -0.02%     
==========================================
  Files         466      466              
  Lines       16628    16628              
  Branches     1350     1350              
==========================================
- Hits        15542    15540       -2     
- Misses        792      793       +1     
- Partials      294      295       +1     

see 3 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

JackPGreen commented 1 year ago

Dependency:Get is 2.8 on the project.

Needs a bump up to 3.6.0 also.

@avtarraikmo I've addressed this - can you review, please?

JackPGreen commented 12 months ago

@srknzl are you able to take a look at this, please?