search

hazelcast / hazelcast-operator

Apache License 2.0
10 stars 14 forks source link

Update readme SSL and 4.0 Operator #6

Closed leszko closed 4 years ago

leszko commented 4 years ago

This PR should be merged after:

leszko commented 4 years ago

@mesutcelik @kwart wrt Cert Manager. Currently I only described the general way of setting security for Hazelcast + mentioned that it works fine with Cert Manager. That is actually what was required for the IBM Certification.

I get your point that it would be nice to have the Cert Manager configuration with Hazelcast here, but I'm a little afraid of the maintenance effort. Like we described Minishift in OpenShift Code Sample and nobody knows if the Minishift steps are valid any mode, because to check it you'd need to spend the whole day.

My idea is to:

  1. Leave it as it is for now (it's good enough for the IBM certification)
  2. Write a blog post describing Cert Manager + Hazelcast Operator configuration (I can write it, or Josef if you want, you can write it)
  3. Link the blog post here in the operator description.

What do you think?

Another idea would be to remove this keystore/truststore description (from both Helm Chart and hazelcast-operator) and add this keys which are injected by Cert Manager, so {ca.crt, tls.key, tls.crt} instead of {keystore, truststore}.

leszko commented 4 years ago

... and some mention about Hazelcast 4.0 support version of the operator. Can you also update those or send separate RP?

Added versions compatibility section.

mesutcelik commented 4 years ago

I see Rafal. The reason I asked because I did not even see the mention to Certificate Manager. Now I see it. I think you can at least put a website link to https://cert-manager.io/docs/

leszko commented 4 years ago

https://cert-manager.io/docs/

Updated with the link