search

hazelcast / hazelcast-simulator

A tool for stress testing Hazelcast
Apache License 2.0
87 stars 72 forks source link

Improve error message when inappropriate driver is used #1888

Open Holmistr opened 4 years ago

Holmistr commented 4 years ago

When using current Simulator on master, which now supports both HZ 3.x and 4.x, I used to have this old simulator.properties:

CLOUD_PROVIDER=static
VERSION_SPEC=maven=4.0.2
VENDOR=hazelcast-enterprise
WORKER_PERFORMANCE_MONITOR_INTERVAL_SECONDS=1
SIMULATOR_USER=simulator

The error thrown is pretty cryptic when running provisioner --install:

sent 95 bytes  received 86 bytes  120.67 bytes/sec
total size is 9,988  speedup is 55.18
Warning: Permanently added '10.212.1.101' (ECDSA) to the list of known hosts.
opening connection using: ssh -o BatchMode=yes -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -l simulator 10.212.1.101 rsync --server -vvlogDtprce.iLsfxC . hazelcast-simulator-0.12-SNAPSHOT/drivers/driver-hazelcast-enterprise/  (15 args)
Warning: Permanently added '10.212.1.101' (ECDSA) to the list of known hosts.
sending incremental file list
rsync: change_dir "/home/jholusa/playground/hazelcast-simulator-0.12-SNAPSHOT/drivers/driver-hazelcast-enterprise" failed: No such file or directory (2)
delta-transmission enabled
total: matches=0  hash_hits=0  false_alarms=0 data=0

sent 20 bytes  received 42 bytes  41.33 bytes/sec
total size is 0  speedup is 0.00
rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1189) [sender=3.1.3]

The root cause is that now the correct VENDOR value is hazelcast-enterprise4 or hazelcast-enterprise3. Would be nicer to provide a reasonable error message.

pveentjer commented 4 years ago

Loading of the driver must have raised an exception. I guess it either isn't properly propagated, or the bash script just continues.