hazelcast / hazelcast-simulator

A tool for stress testing Hazelcast
Apache License 2.0
87 stars 74 forks source link

Make inherited test methods follow JUnit conventions #2237

Closed k-jamroz closed 1 week ago

k-jamroz commented 1 week ago

Fixes test method inheritance to follow JUnit conventions: preparation methods should be executed from superclass first and later from subclass, after test methods in the opposite order. Previously search finished on first class containing method with given annotation (see findAllDeclaredMethods).

This changes previous behavior, but because it was hardly useful it is assumed that nobody relied on it.

k-jamroz commented 1 week ago

LGTM, thanks @k-jamroz - my only question: is there any expected impact on existing tests using simulator?

I checked tests inheriting from HazelcastTest: