search

hazelcast / hazelcast-tomcat-sessionmanager

Tomcat Based Web Session Replication
Other
33 stars 37 forks source link

Added auto-configuration for Spring Boot #103

Closed alparslanavci closed 3 years ago

alparslanavci commented 3 years ago

Fixes #73.

alparslanavci commented 3 years ago

@enozcan yes, you are correct. This is a known issue, and actually, it requires much larger refactoring. Maybe we can create a GH issue for tracking, but I am pretty sure that it needs a larger effort to fix it in general.

leszko commented 3 years ago

@leszko, you got the exception because most likely you haven't added Hazelcast to the classpath. It should be also provided, I'll update the readme accordingly.

Wouldn't it be possible to detect it at runtime and give a proper warning/error message?

leszko commented 3 years ago

@leszko regarding the error you got, we cannot give a proper error message for that since the exception is thrown from Spring Boot itself.

Wouldn't it work if you check it somewhere here? I mean to check if you have Hazelcast on the classpath?

The other option is to change the Hazelcast dependency scope to not be provided. What do you think?