search

hazelcast / hazelcast-wm

Hazelcast filter-based Web Session Manager
Other
12 stars 31 forks source link

Allow non-string configuration values for the filter. #97

Closed OmarMorales71 closed 3 years ago

OmarMorales71 commented 3 years ago

Method getValue try to get a property with a string value (getProperty()). When you try to get a Boolean property, this method return a null (because it just can get String values) and that's the reason the app put the default value to that property.

I fixed it using the get() method instead getProperty(). get() return an Object and after that I cast it to the type of value I need (in this case Boolean).

Check List:

Fixes #95 Unit tests : YES

devOpsHazelcast commented 3 years ago

Can one of the admins verify this patch?

devOpsHazelcast commented 3 years ago

CLA assistant check
All committers have signed the CLA.

enozcan commented 3 years ago

Thanks for the PR @OmarMorales71! I will work through WebFilterConfig and review asap.

enozcan commented 3 years ago

verify

OmarMorales71 commented 3 years ago

@enozcan I have fixed what you asked for. I checked that my solution works with boolean, int, double, etc. (not just boolean).

enozcan commented 3 years ago

verify

enozcan commented 3 years ago

verify

enozcan commented 3 years ago

Thanks for the PR @OmarMorales71!