search

hazelcast / hz-docs

Source content for the Hazelcast Platform documentation
10 stars 92 forks source link

Clarification about client use public ip property #1108

Closed srknzl closed 3 weeks ago

srknzl commented 2 months ago

See https://hazelcast.slack.com/archives/C01JU7ZJYGP/p1715012564100079

the property is not described well enough. in this pr I am fixing this.

note: this is kinda tricky information to add. it's in the conjunction of smart/unisocket, discovery and network/address list topics, each have their own sections. So pls advise if I can improve this pr.

netlify[bot] commented 2 months ago

Deploy Preview for hardcore-allen-f5257d ready!

Name Link
Latest commit 2abf8316db9aeb21b8944703a6edcfe907801b4d
Latest deploy log https://app.netlify.com/sites/hardcore-allen-f5257d/deploys/663b7a86861c1600082dffc0
Deploy Preview https://deploy-preview-1108--hardcore-allen-f5257d.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

srknzl commented 2 months ago

thanks for the reviews 🙏🏻

@rebekah-lawrence hopefully I didn't make a mistake, I should have applied via github UI. I manually edited files, so if I missed any of the changes, please tell me. You can go over once more to ensure that didn't happen

srknzl commented 1 month ago

@ihsandemir can you have a look at this again pls?