Closed JackPGreen closed 1 week ago
LGTM but suggested removing the hide-nav links
Thanks but I'm not sure I understand the difference?
I've also realised that I've linked to the documentation using a "regular" link to the latest docs - but as were in the documentation it probably should've been versioned (i.e. 5.3
's docs should probably link to the 5.3
client page).
I think it'd have been better if I'd used the proper adoc linking syntax instead - do you know what that'd be, please?
I think it'd have been better if I'd used the proper adoc linking syntax instead - do you know what that'd be, please?
You mean like this?
xref:{page-latest-supported-mc}@management-center:getting-started:overview.adoc[Management Center docs]
(from: https://github.com/hazelcast/hz-docs/blob/main/docs/modules/ROOT/pages/management-center.adoc)
I think it'd have been better if I'd used the proper adoc linking syntax instead - do you know what that'd be, please?
You mean like this?
xref:{page-latest-supported-mc}@management-center:getting-started:overview.adoc[Management Center docs]
(from: https://github.com/hazelcast/hz-docs/blob/main/docs/modules/ROOT/pages/management-center.adoc)
Thanks, but I think it's a non-issue now. It was only the Java client docs that linked to another page within the same repo (hz-docs
) but via the external URL.
✅ Deploy Preview for hardcore-allen-f5257d ready!
Toggle QR Code...
Use your smartphone camera to open QR code link.
To edit notification comments on pull requests, go to your Netlify site configuration.