netlify[bot]
commented
4 days ago Deploy Preview for hardcore-allen-f5257d ready!
| Name | Link |
|---|---|
| Latest commit | 5dd0d4f54f177d55d8bc43fca0362f63c9007a6d |
| Latest deploy log | https://app.netlify.com/sites/hardcore-allen-f5257d/deploys/6740bb22d1172d0008203f90 |
| Deploy Preview | https://deploy-preview-1382--hardcore-allen-f5257d.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
JackPGreen
This PR adds an action that will, when a PR is opened, check the resolvability of any external links.
External links are defined as those using the
httpscheme - internal links between documentation is already covered by our existing dead links check.Action is deliberately modular to be be easily applied to other docs repos.
This runs whenever a PR is raised, which is sub-optimal because:
But the other alternative - a scheduled check - would have difficulty in knowing who to target a failure communication at to resolve the issues (other projects notify Slack channels, with varying degrees of responses).
An example of the output produced by this action can be found here.
Note that the external link check fails because of dead links, and won't pass until the following are addressed:
URL 'https://raw.github.com/olivernn/lunr.js/master/lunr.min.js' had status 404 (found in node_modules/lunr/index.html)We should consider whether adding a check that we know will fail is a good idea - comparing the annoyance of a failing (non-blocking) test against the coverage that at least we can ensure things don't get worse.
Fixes: DOC-253