search

hazendaz / displaytag

MIT License
26 stars 20 forks source link

Version 3.0.2 breaks boolean and date sorting #773

Open chris-1o opened 4 weeks ago

chris-1o commented 4 weeks ago

Columns defined as below are not properly sorted anymore since version 3.0.2.

<display:column property="certificateExpirationDate" titleKey="labels.destination.certExpirationDate" sortable="true"
        sortName="certExpirationDate" format="{0,date,dd-MM-yyyy HH:mm:ss}"/>

<display:column titleKey="labels.destination.isVisible" sortable="true" sortName="isvisible">
        <fmt:message key="address.isvisible.${address.isVisible}"/>
    </display:column>

A downgrade to 3.0.1 fixes the issue.

hazendaz commented 3 weeks ago

See https://github.com/hazendaz/displaytag/pull/661/files as that is likely where the problem started. Possibly if you could try to rework that so it still solves the purpose it was opened for as well as the issue you are facing. I don't have a lot of spare time so if I have to do it, it will be a little while. I can release really quickly if you could get a fix that works out. It would be highly appreciated otherwise no ETA.