search

hazendaz / javabean-tester

JavaBean Tester
http://codebox.org.uk/pages/articles/unit-testing-javabeans
Apache License 2.0
9 stars 5 forks source link

changed ByteBuddy invocation to do proper instanceof check, made it s… #834

Closed pthptht closed 3 months ago

pthptht commented 3 months ago

…o Extended class is inserted to the same package in classpath.

Note: doesn't seem to change test coverage, but did comment out all *WithExtension derived tests locally, and seems to run with no change in coverage.

coveralls commented 3 months ago

Coverage Status

coverage: 88.425% (-0.1%) from 88.571% when pulling 3e65b3c5d6de8ef60f4915cd24aafbfe075ce9a0 on pthptht:extensionPartDeux into 96f66cdfb54c1096098a3a149f144adfb14e55dc on hazendaz:master.

hazendaz commented 3 months ago

@pthptht Well lets give it a go. I have plenty of beans to test this against that were all using extensions. Its been so long I don't know what really happened last go around other than lombok didn't quite work well with this due to AST. This seems promising but considering that was rather mainline I half wonder if it silently did much of nothing for a long time. Will get a release out this weekend and that will give us some time to test it next week! Thanks for the PR.