hazuki0x0 / YuzuBrowser

Customizable browser for android
Apache License 2.0
319 stars 96 forks source link

"save search engine switching" broken #217

Open VDK opened 3 years ago

VDK commented 3 years ago

Describe the bug Another search engine than was selected gets saved.

To Reproduce Steps to reproduce the behavior:

  1. Enable "Save Search engine switching" under browser settings > search settings
  2. Select a different search engine
  3. Open/close a tab
  4. See a different engine being selected The pattern what other engine is selected is highly unpredictable. Number 1 and 2 work fine. 3-7 seems to always revert back to nr. 1. Selecting 8 makes 7 stick, 9 to 8 but then selecting 16 makes 12 stick.

Expected behavior The search engine that I had switched to gets sticky, not another one. What also has changed is that a switch in search engine affects what search engine gets used when search is initiated from the context menu of selected text. Before this was done with the main search engine that was selected in "search engine settings", very much how I'd prefer it. Now it seems the search engine that strings are routed to is the engine that was last selected, not some random other engine.

Device information (please complete the following information):

Additional context I have a very long list of search engines that I switch between.