search

hazzik / mpqtool-export

Automatically exported from code.google.com/p/mpqtool
0 stars 1 forks source link

DetectFileSeed off by one (possibly?) #2

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I don't have an mpq that requires seeds to be found so I can't test this, 
however, your code for DetectFileSeed contains the line:

uint saveseed1 = seed1;

Where the original source you were porting from contains the lines:

/* Add 1 because we are decrypting block positions */
saveseed1 = seed1 + 1;

I have no idea if this was intentional, just remarking on the difference.

Original issue reported on code.google.com by lei...@gmail.com on 30 Aug 2006 at 9:09

GoogleCodeExporter commented 9 years ago 
Thanks for the remark. I'll look into it.

Original comment by mmo...@googlemail.com on 13 Nov 2006 at 2:46

GoogleCodeExporter commented 9 years ago 
I wrote this over a year ago so I can't remember why it was written this way, 
but the
code does work correctly.  The MpqReader code was written for the SCSharp 
project. 
Starcraft does have encrypted files so I was able to test it with them.

Original comment by fool...@gmail.com on 23 Jul 2007 at 9:02

GoogleCodeExporter commented 9 years ago 
Closing this issue as there is no evidence that the code is not working 
correctly.

Original comment by fool...@gmail.com on 26 Jul 2007 at 9:28