hbagdi / go-unsplash

Go Client for the Unsplash API
https://unsplash.com
MIT License
74 stars 13 forks source link

Improved error processing; Not really, onus on the dev-user #30

Closed hbagdi closed 7 years ago

hbagdi commented 7 years ago

Dump HTTP body on errors into ErrString of the Error() returned; return error on all but 20x responses. This will fix #23 #5 #22

codecov[bot] commented 7 years ago

Codecov Report

Merging #30 into master will decrease coverage by 0.07%. The diff coverage is 78.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
- Coverage   86.59%   86.51%   -0.08%     
==========================================
  Files          16       16              
  Lines         649      660      +11     
==========================================
+ Hits          562      571       +9     
- Misses         49       51       +2     
  Partials       38       38
Impacted Files Coverage Δ
unsplash/response.go 78.66% <78.94%> (+0.54%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update de4507b...02c2172. Read the comment docs.

codecov[bot] commented 7 years ago

Codecov Report

Merging #30 into master will decrease coverage by 0.07%. The diff coverage is 78.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
- Coverage   86.59%   86.51%   -0.08%     
==========================================
  Files          16       16              
  Lines         649      660      +11     
==========================================
+ Hits          562      571       +9     
- Misses         49       51       +2     
  Partials       38       38
Impacted Files Coverage Δ
unsplash/response.go 78.66% <78.94%> (+0.54%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update de4507b...02c2172. Read the comment docs.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.06%) to 89.359% when pulling 02c21726a4fc252a5d55681a70d33c1eaed56a83 on response_errors into de4507b2bc9d1afe2bf67b2c22f70165380a8d52 on master.