search

hbakkum / rundeck-hipchat-plugin

Sends rundeck notification messages to a HipChat room
Apache License 2.0
15 stars 15 forks source link

HipChat Server #3

Closed wjimenez5271 closed 9 years ago

wjimenez5271 commented 10 years ago

With the addition of Hipchat Server it now becomes important to be able to specify the server url. Would it be possible to have that parameterized?

wjimenez5271 commented 10 years ago

I tried changing the value of HIPCHAT_API_BASE from HipChatNotificationPlugin.java to reflect a local Hipchat instance, and rebuild using maven, but when I loaded the jar Rundeck reported an error:

service.log:ERROR JarPluginProviderLoader: /var/lib/rundeck/libext/rundeck-hipchat-plugin-1.2.1-SNAPSHOT-javadoc.jar: Jar plugin manifest attribute missing: Rundeck-Plugin-Archive

hbakkum commented 10 years ago

Hi there,

Sure, I'll look into getting that value parametrized for hipchat server users. Not sure if your noticed yet, but that error your getting looks to be due to the plugin javadoc jar (rundeck-hipchat-plugin-1.2.1-SNAPSHOT-javadoc.jar) being copied into the plugin directory. The jar you should use is rundeck-hipchat-plugin-1.2.1-SNAPSHOT.jar - let me know if you have any problems with that.

Cheers, Hayden

hbakkum commented 10 years ago

Ok, so I've just pushed some code changes that will allow you to optionally specify a base URL for a hipchat server instance. You can configure this in either project.properties or framework.properties:

configure project: project.plugin.Notification.HipChatNotification.hipchatServerBaseUrl=https://myhipchatserver.com configure framework: framework.plugin.Notification.HipChatNotification.hipchatServerBaseUrl=https://myhipchatserver.com Default value: https://api.hipchat.com

I've tested that specifying the property takes effect but I don't have a hipchat server instance available (looks like I'd need to submit a request to Atlassian to download a beta version). If you have a hipchat server installed, are you able to build a plugin snapshot and test against this?

wjimenez5271 commented 10 years ago

Hi Haden We just switched back to hosted Hipchat so unfortunately I don't have a way to test this anymore. Thanks for making this work though, there seems to be a growing number of users trying out Hipchat server so I am sure this will be useful. I've seen other plugins follow suit, such as: https://marketplace.atlassian.com/plugins/com.atlassian.labs.hipchat.hipchat-for-jira-plugin/versions.

-William