search

hbakkum / rundeck-hipchat-plugin

Sends rundeck notification messages to a HipChat room
Apache License 2.0
15 stars 15 forks source link

Proxy Support #7

Closed jplock closed 9 years ago

jplock commented 9 years ago

Fixes #6

hbakkum commented 9 years ago

Hi,

Thanks for submitting this request. Proxy changes look good, I'll test this out today and merge in the changes. Can I ask why the @Overrides gives you errors in eclipse - is this because source level is set to 1.5 or something else?

Thanks, Hayden

jplock commented 9 years ago

I'm not sure. I'm using JDK8 at this point with the latest eclipse and it would not compile with those @Override's in there

hbakkum commented 9 years ago

Ok, I've tried the latest eclipse with Java 7 and I do get the same errors. It seems by default eclipse sets the compiler compliance level to 1.5 even though I'm using Java 7. Changing the compliance level to 1.6+ addresses the issue so I'm going to leave those @Overrides in there.

So I've just cherry-picked those other commits. I made a few changes on top of those:

I've now released that as version 1.5.0 of the plugin - should sync out to maven central in the next hour or so.

Thanks again for this, please let me know if you have any more feedback in the plugin or if there are any other features you'd like to see.

Cheers, Hayden