hbang / NewTerm

NewTerm is a terminal emulator app with first-class iPhone, iPad, and Mac support.
https://newterm.app
Other
463 stars 71 forks source link

Rewrite of SafariView (old) #73

Closed chrisharper22 closed 2 years ago

chrisharper22 commented 2 years ago

Once again, this is a rewrite of the SafariView. This, however, will make the NavigationView push the Safari controller instead of using a sheet (but the latter is still an option). This creates a better UX, as it follows how Safari controllers are presented in other iOS apps. This change does not require changes in pre-existing uses of .safariView(), as it is done all under the hood. (However, because pushing in the Navigation stack does fix the collapsing bar issue (at least on SwiftUI previews?), the SafariView.Configuration used in SettingsAboutView has been modified accordingly).