hbang / TermHere

Finder extension for opening a terminal from the current directory
https://hbang.com.au/termhere
Apache License 2.0
110 stars 11 forks source link

Sierra Support #9

Closed erikng closed 8 years ago

erikng commented 8 years ago

Looks like it no longer works after upgrading. Confirmed the extension is still enabled.

iAdam1n commented 8 years ago

We're aware of this.

kirb commented 8 years ago

I'm a bit behind right now but still expect to have TermHere 1.2 submitted to Apple shortly. A few features need finishing first. (Not sure how long it will take Apple to review/approve considering Sierra just came out.)

funkenstrahlen commented 8 years ago

I also just discovered this bug. Happy to see your are already working on a fix. Thanks a lot :)

RudyB commented 8 years ago

What is the status of the update?

iAdam1n commented 8 years ago

Hi @RudyBermudez, details on the update can be found at https://www.reddit.com/r/hbang/comments/54fbor/termhere_12/.

kirb commented 8 years ago

Arg I didn’t link the release post here – sorry! It’s… not quite going too well. App Review doesn’t agree with the method I’ve changed to using in order to support Sierra (and to add more features), and is pushing me onto their paid developer support service rather than just suggesting a supported alternative. I’m lost on what I should do here; TermHere sits very close to the limits of the sandbox, so moving outside of the App Store would remove a heap of stress/uncertainty when releasing updates but adds the stress/inconvenience of getting people onto the new app.

erikng commented 8 years ago

I would say that most people using this application are power users and would have no difficulty moving to a non Mac App Store version.

Is the fear getting the message? If so, maybe remove this feature and put a message inside the App Store version explaining that you can't enable the feature and to look at your website for more information.

It would require forking your code but only this one time.

I wouldn't use their developer service either. You will just pay to get a "No".

On Oct 18, 2016, at 2:09 AM, Adam Demasi notifications@github.com<mailto:notifications@github.com> wrote:

Arg I didn't link the release post here - sorry! It's... not quite going too wellhttps://www.reddit.com/r/hbang/comments/54fbor/termhere_12/. App Review doesn't agree with the method I've changed to using in order to support Sierra (and to add more features), and is pushing me onto their paid developer support service rather than just suggesting a supported alternative. I'm lost on what I should do here; TermHere sits very close to the limits of the sandbox, so moving outside of the App Store would remove a heap of stress/uncertainty when releasing updates but adds the stress/inconvenience of getting people onto the new app.

You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/hbang/TermHere/issues/9#issuecomment-254450655, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFa_GHHVAeW-ymEgxYYgZ86yp3GZIKlvks5q1IzLgaJpZM4KDSFi.

RudyB commented 8 years ago

I agree with @erikng . I would not mind a non-app store release at all. Honestly whatever gets the fix in my hands the fastest. Adding an automatic update feature would not be that difficult to implement. You could even self-host the application download on github.

You would just have to update the mac application with a message saying that it is deprecated and to the version hosted here.

liufsd commented 8 years ago

i wonder that if you use this key ,the apple review will not pass.as i know apple do not allow this key.

com.apple.security.temporary-exception.apple-events

liufsd commented 8 years ago

but i do not know why "go2shell" in app store

kirb commented 8 years ago

That’s exactly what I used/what Apple disagreed with. https://github.com/hbang/TermHere/blob/master/TermHere/TermHere.entitlements

liufsd commented 8 years ago

Yeah, i have also trouble with this.and even i have found this http://stackoverflow.com/questions/12858642/mac-app-rejection-temporary-exception-entitlement-key-for-safari https://forum.xojo.com/24364-how-can-you-determine-what-entitlements-an-app-is-using/0 but also rejection.

liufsd commented 8 years ago

If you got solution,please tell me.thanks.

liufsd commented 8 years ago

hi~ why this app (https://itunes.apple.com/cn/app/termhere/id1114363220?mt=12&ign-mpt=uo%3D4) can submit on app store? but not working on 10.12~ So i have question: if you set this https://github.com/hbang/TermHere/blob/master/TermHere/TermHere.entitlements , the app not allow you to this . how did you submit it to store?

liufsd commented 8 years ago

@kirb Do you fix this ??? The apple allow you to do this or not now ???

kirb commented 8 years ago

The version we just released on our website is not sandboxed and works with Sierra.

liufsd commented 8 years ago

@kirb aha this is a good news~ and also bad news for apple~

erikng commented 8 years ago

FYI but https://hbang.com.au/termhere Still points to App Store.

kirb commented 8 years ago

Ah good catch @erikng, knew I missed something in all the effort to release this. Redirects to the hbang.ws page now.