search

hbanzhaf / steering_functions

Apache License 2.0
229 stars 94 forks source link

added missing install targets #1

Closed marc-hanheide closed 6 years ago

marc-hanheide commented 6 years ago

as the title says... this package didn't have any install targets.

marc-hanheide commented 6 years ago

I had to change the header installation as it was only working for *.h 😠 fingers crossed...

marc-hanheide commented 6 years ago

I had it for *.h files only initially, but then obviously the hpp files were missing. So I made a commit installing all *.h* files, but you also have a *.data that needs to be installed as a header file... Hence my all-inclusive install. You'll have to change some more if I were to just install *.h.

marc-hanheide commented 6 years ago

Last question: I think I cannot retrospectively sign off, can I? I don't want to force push to change past commits. Any other way?

hbanzhaf commented 6 years ago

Hi Marc, I will merge your pull request as soon as all commits are signed-off. Please make sure that the sign-off appears in every commit message with your name and a valid email address according to:

Signed-off-by: Random J Developer <random@developer.example.org>

You can achieve this by running the git-commit command with the -s option. Further details can be found here.

Apart from a force push I only see the option of creating a novel pull request with the sign-off appended to every commit message.

Sorry for the inconvenience, Holger

marc-hanheide commented 6 years ago

2 is the proper one, so this one should be closed.