hbenl / vscode-test-explorer

The VS Code Test Explorer extension
MIT License
215 stars 55 forks source link

add testExplorer.useNativeTesting setting #199

Closed hbenl closed 3 years ago

hbenl commented 3 years ago

@connor4312 Here's the PR for the changes we talked about. I would suggest that you register/unregister your converter whenever the testExplorer.useNativeTesting flag changes. By the way, you probably don't need to worry about missing events if you register the converter late: you will miss events for past test runs, but not those for loading the tests: when an adapter sends its test tree, the TestHub remembers it and when a controller registers later on, the TestHub will send "synthetic" load events containing the test tree to it.

connor4312 commented 3 years ago

Thanks, looks good! I've updated the converter accordingly. A few things:

hbenl commented 3 years ago

I've just published this.

connor4312 commented 3 years ago

Thanks! Realized I forgot to push the updates to the converter extension, I've now done so in 0.0.8

TylerLeonhardt commented 3 years ago

@hbenl I think you can re-add the extension dependency now. Right @connor4312?

connor4312 commented 3 years ago

Yep

hbenl commented 3 years ago

@TylerLeonhardt Thanks for the reminder.