hbenl / vscode-test-explorer

The VS Code Test Explorer extension
MIT License
215 stars 55 forks source link

VSCodium cannot activate extension #216

Open act28 opened 3 years ago

act28 commented 3 years ago

Not sure if this is a VSCodium issue or an extension issue.

Problem

VSCodium cannot activate extension because it depends on an unknown ms-vscode.test-adapter-converter extension

What I tried

Install ms-vscode.test-adapter-converter fails with Unable to install extension 'ms-vscode.test-adapter-converter' as it is not compatible with VS Code '1.57.1'.

Description

From the ms-vscode.test-adapter-converter Marketplace page:

This is an extension that converts from the Test Explorer UI API into native VS Code testing. When using this, you will likely want to disable the test explorer UI components.

Yet ms-vscode.test-adapter-converter is not listed as a dependency in Test Explorer UI?

I am unable to downgrade VSCodium to 1.56 to see if it's just a version issue with the adapter-converter.

tomrobin-teschner commented 3 years ago

I'm having the same issue on vscode from today (it seems after updating to v1.57 though I have tried with v1.56 and it doesn't work there either). I am getting the following error:

Cannot activate the 'Test Explorer UI' extension because it depends on the 'Test Adapter Converter' extension, which is not loaded. Would you like to reload the window to load the extension?

After reloading, I get the same message again (and the test adapter converter is not loaded). This only appears when using WSL both on Ubuntu 18.04 and 20.04. If I don't connect to a remote WSL session, the test explorer UI loads as expected on the side bar.

EDIT: Just tested on Ubuntu 20.04 LTS, the issue does not appear here. Maybe a WSL issue? (I tested with both WSL 1 and WSL 2, both don't work)

kerero commented 3 years ago

It is also unusable with dev-containers at the moment.

hbenl commented 3 years ago

Since these are issues with the Test Adapter Converter extension, here are the relevant issues in the repository for that extension: microsoft/vscode-test-adapter-converter#6 microsoft/vscode-test-adapter-converter#5

I hope that Microsoft will fix these soon, otherwise I'll have to remove the extension dependency for now.

Yet ms-vscode.test-adapter-converter is not listed as a dependency in Test Explorer UI?

It is listed as an extensionDependency (because extension dependencies are handled differently than the regular dependencies)

pcjmfranken commented 3 years ago

The test-adapter-converter seems to activate - or attempt to and fail in my case - even with testExplorer.useNativeTesting explicitly set to false.

Is it possible to load dependencies conditionally?

kerero commented 3 years ago

Seems the problem got resolved (with the new vscode update?).

act28 commented 3 years ago

Can confirm. Resolved by upgrading to 1.58.1.

tyler36 commented 3 years ago

It's working here too on 1.58.1

Although, I noticed that the "Test Adapter Convert" was updated to 0.0.13 an hour ago. Looking at the original error message, it might be related to the extension version rather than VSCode version?

pcjmfranken commented 3 years ago

@tyler36 The part of the issue that involves remotes looks to have indeed been a problem with the converter extension and was fixed here https://github.com/microsoft/vscode-test-adapter-converter/commit/5881ec1a44d0751fd3e0e9e61db8eadd84149e12

tomrobin-teschner commented 3 years ago

Can confirm, for me it works as well again (vscode 1.58.0 still but test adapter converter 0.0.13) on windows using WSL (Ubuntu 20.04)

tyler36 commented 3 years ago

TLDR: VSCode 1.58 with Test Adapter Convert 0.0.13 working.

Until there's a stable release of test-adapter-converter (or whatever system it morphs into), this type of issue will probably crop up again from time to time.

Probably should close ticket since OP, and several others, have confirmed it's no longer an issue.

act28 commented 3 years ago

FWIW, I installed test-adapter-converter from marketplace downloaded VSIX, so my current version ~is~ was still 0.0.10. Update to 0.0.12 (downloaded 8th July) also works. 0.0.15 (current version released 14th July) is incompatible with 1.58.1.

valdeniomarinho commented 3 years ago

It is not working with WSL2.