search

hbenl / vscode-test-explorer

The VS Code Test Explorer extension
MIT License
214 stars 55 forks source link

Enabling "Use Native Testing" hides test icon on reboot #226

Open TheRubeThing opened 3 years ago

TheRubeThing commented 3 years ago

Yesterday I was notified by this extension if I wanted to try the native testing UI. I clicked yes and everything worked great. Next time I opened VSCode the testing button(laboratory flask) was gone. Opening the settings and disabling the Use Native Testing option brings the button back. If I enable it again the button disappears. However if my active panel is the testing panel while enabling the setting the button stays until I quit and reopen VSCode.

Either a bug or I've missed something about how to access this Native testing UI after the extension button disappears but I haven't been able to find anything online.

hbenl commented 3 years ago

I haven't seen this issue with Mocha Test Explorer, so it seems to be caused by the Test Adapter extension. Which one are you using? Perhaps that extension is set to only activate when the Test Explorer view of this extension is visible, but not when the native Test Explorer view is visible. That would explain the behavior: if you start VS Code without native testing, the extension activates and remains activated when you switch to native testing, but if you start VS Code with native testing, the extension never gets activated.

matepek commented 3 years ago

Same issue here. I added activationEvent "onView:workbench.view.testing" but didn't help.

matepek commented 3 years ago

For mocha you have:

  "activationEvents": [
    "*"
  ],

For me it is more specific. I liked (and I hope that my users liked it too) that the adapter extension were activated when the user clicked on the Test icon on the sidebar (onView:test-explorer). This can save resources. I've also added workspaceContains:/.vscode/testMate.cpp.json in someone really wants to activate.

I assume that since no adapter is installed (because my adapter is not) vscode doesn't show the icon. A dummy empty adapter it could be a workaround.. but might just asking vscode to force show that damn icon is a better choice.

hbenl commented 3 years ago

We need some way to show the test icon before a test extension is activated, I created an issue in the VS Code repo for this.